Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: Vomnibar active in new window #263

Closed
casprwang opened this issue Dec 20, 2020 · 8 comments
Closed

feature request: Vomnibar active in new window #263

casprwang opened this issue Dec 20, 2020 · 8 comments

Comments

@casprwang
Copy link

casprwang commented Dec 20, 2020

Something like Vomnibar.activateInNewWindow. Also, It would be awesome to have a macro for opening a Vomnibar selection in a new window(cmd/ctrl+shift+enter?)

Many thanks!

@gdh1995
Copy link
Owner

gdh1995 commented Dec 20, 2020

Accepted. I'll add it but recently I have little rest time - maybe it won't arrive until the further v1.88, in about one month.

@casprwang
Copy link
Author

Thank you! And of course, please take care of yourself first.

gdh1995 added a commit that referenced this issue Dec 28, 2020
@gdh1995
Copy link
Owner

gdh1995 commented Jan 4, 2021

Hello, v1.88.0 has been released, and if you add clickLike="chrome" to mappings of Vomnibar.activate***, then Ctrl/Alt/Shift will work like Chrome itself deals with your click. So Shift+Enter will open in a new window.

(updated) For example: map o Vomnibar.activate clickLike="chrome"

@casprwang
Copy link
Author

hmm, it seems map o LinkHints.activate clickLike="chrome" opens a new tab for me, not a window.

map t Vomnibar.activateInNewTab
map h previousTab
map l nextTab
map gq removeTab
map Q restoreTab
unmap W
map W moveTabToNewWindow
map gj closeDownloadBar
map f LinkHints.activate autoUnhover
map o LinkHints.activate clickLike="chrome"

@gdh1995
Copy link
Owner

gdh1995 commented Jan 4, 2021 via email

@casprwang
Copy link
Author

casprwang commented Jan 4, 2021

no luck... here's a gif with keys presses

2021-01-04 10 34 07

@gdh1995
Copy link
Owner

gdh1995 commented Jan 5, 2021

Well. My last comment has a typo, and it should be map o Vomnibar.activate clickLike="chrome".

LinkHints currently doesn't support switch to new-window mode by Ctrl/Shift/Alt, but you can use a special mapping with newtab="window" option to make hint markers do so.

@casprwang
Copy link
Author

Ah, I see. It works now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants