LinkHints gets a wrong view area if page is zoomed on Chrome for macOS #119

agzam · 2020-02-02T22:30:57Z

It's missing urls sometimes.
Here's for example of a GitHub page, when f pressed, you can clearly see that all wiki links are ignored.

Just in case I checked if the same thing is also broken in Vimium and it is not. Vimium still recognized all links on the page

upd: Apparently when content zoomed-in to the point when devicePixelRatio exceeds 2, link hinting breaks.

upd 2: This turned out to be specific to OS X and the way how it handles scaling. I failed to reproduce the issue on any other display, it only appears on the Macbook's internal retina display with scaled resolution.

The text was updated successfully, but these errors were encountered:

Monirzadeh · 2020-02-02T22:47:23Z

just for test
press F2 in hint mode makes any different?
Update: can you disable all other extension and test again?

Monirzadeh · 2020-02-02T22:57:04Z

it's the same - incognito in Chrome, private in Brave, still missing the links. F2 has no effect whatsoever, what that suppose to do?

i just test , may be it is like this situation here

Monirzadeh · 2020-02-02T23:27:35Z

i test same page in brave (Vimium wiki) and it's work for me without any problem so i think something interrupt the extension
this is my screenshot on brave and Vimium C 1.80.1 on Linux

gdh1995 · 2020-02-02T23:55:03Z

I've applied some aggressive rules to exclude some of useless hints and add some other exact ones. Uh, so maybe that's a regression bug compared with an old version. I will do some tests in this week. But from today my annual holiday has ended，so the development of Vimium C will slow down.

…

---Original--- From: "Ag Ibragimov"<notifications@github.com> Date: Mon, Feb 3, 2020 07:05 AM To: "gdh1995/vimium-c"<vimium-c@noreply.github.com>; Cc: "Subscribed"<subscribed@noreply.github.com>; Subject: Re: [gdh1995/vimium-c] Missing links (#119) Okay, so I tried pressing f then scroll a bit, then F2 - some links get recognized, but again - not all. The workaround suggested in the linked issue unfortunatley is not a solution. This bug pretty much makes this extension unusable outside of Firefox. I see that the reason how this feature is implemented differently from Vimium (classic) is for performance reasons. Maybe there's a flag that can be tweaked? I'd rather have all visible links on the page to be hinted, even if it slightly makes it slow. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

gdh1995 · 2020-02-03T01:29:13Z

Hello, I didn't see the snapshot when I replied through email. According to these snapshot, it should be because Vimium C gets a wrong "visual viewport" (visible area).

So what's your screen DPI, browser and its version code, opearting system and its version ? Thanks for this report.

gdh1995 · 2020-02-03T02:17:20Z

What's the result of visualViewport and devicePixelRatio?

gdh1995 · 2020-02-03T02:38:56Z

Is the size of your Chrome window maximized?

On my computer, visualViewport.width is near to innerWidth (their delta means a scrollbar), and innerWidth * devicePixelRatio is approximate to the width of screen resolution.

So could you provide info of screen, innerWidth, innerHeight, visualViewport of a tab in a maximized Chrome window (the Developer Tools should in a seperate window)?

gdh1995 · 2020-02-03T03:39:39Z

Have you zoomed-out on github.com by Command+-?

gdh1995 · 2020-02-03T04:06:00Z

vimium_c-1.80.1-dist-no-visualviewport.zip

What about this version? I removed visualViewport from LinkHints.

gdh1995 · 2020-02-03T06:30:29Z

What it will be if zoom-out and make devicePixelRatio be 1 on a page's web console, on your Mac's bulitin monitor?

agzam · 2020-02-03T06:37:16Z

I'm even trying to zoom on my external monitor so its devicePixelRatio goes above 3 and it still hints all visible links.

gdh1995 · 2020-02-03T06:37:52Z

Have you tested a case when your external monitor was disconnected?

agzam · 2020-02-03T06:39:06Z

Yes, I can reproduce the bug on Macbook's display with good consistency (with or without external display connected). Alas, I'm failing to repro it on any other display. I will try this tomorrow at work (I have some shitty old monitors there)

gdh1995 · 2020-02-03T06:46:31Z

[+getComputedStyle(document.documentElement).zoom, devicePixelRatio] when zoom in/out?

agzam · 2020-02-03T07:00:20Z

Holy shit. This is what I did:

And it now works fine. It's a scaling problem with OSX and Chromium I guess.
I am very sorry for causing you so much trouble with this. It's probably better if fixed, but I guess it's not such a big deal. I'm not sure though how exactly Vimium (classic) handles this.

gdh1995 · 2020-02-03T07:02:47Z

Oops, then this issue is because of one of my tricks to support the zoom CSS style on document.documentElement:

on my Win 10, there's a period that document.documentElement's zoom keeps the same as devicePixelRatio, if only there're no CSS styles setting it.
but this "feature" (or Chrome bug?) is not reproduced on Chrome 79, my Win 10...
then Vimium C tends to think "there's a zoom from page styles" since getComputedStyle(document.documentElement).zoom returns a different value, so it crops some right and bottom hints.

I'll fix it in days. Thanks for your patience and tests.

BTW, this feature is since Chrome 61 on Windows:

vimium-c/types/compatibility.d.ts

Lines 303 to 304 in cd78cea

    
           // a bug that special style.zoom may not work is fixed since MinASameZoomOfDocElAsdevPixRatioWorksAgain 
        
           MinDevicePixelRatioImplyZoomOfDocEl = 61,

agzam · 2020-02-03T07:10:03Z

Ah, okay. Yeah, feel free to ping me anytime if you want me to run another test. It would suck if OSX users with Chromium browsers decide not to use the extension because of this bug. Thank you for your help.

gdh1995 · 2020-02-03T08:24:41Z

Um, I want to know what's [+getComputedStyle(document.documentElement).zoom, devicePixelRatio] when screens' system DPIs are larger than 1, and the test page is not zoomd (aka. zoom level = 100%) by Chrome:

on the built-in monitor, and not "open in low resolution"
on the external monitor, and not "open in low resolution"
on the built-in monitor, and enable "open in low resolution"
on the external monitor, and enable "open in low resolution".

gdh1995 · 2020-02-03T12:41:38Z

As far as I've got, the wrong result occurs when:

enable the "open in low resolution" checkbox
open Chrome on the bulit-in monitor

1. then getComputedStyle(document.documentElement).zoom will return the browser-level zoom ratio, while is not equal with JavaScript's window.devicePixelRatio (which should be physical DPI * browser-level zoom).

if zoom-in a page and make its browser-level zoom ratio larger than 1 (like 110%, 125%, 150%...),

1. then getComputedStyle(document.documentElement).zoom will return 1.1 / 1.25 / 1.5 / ...

Are these right? If they're, then there seems no good way to detect such a bug, and maybe a new option is necessary to manually work it around (let you tell Vimium C what's the basic DPI).

agzam · 2020-02-04T19:21:13Z

I'm not following you, with "open in low resolution" I can no longer reproduce the bug. Only when the checkbox is "off" I can reproduce it, and only on the Macbooks internal display. Maybe it's really not worth wasting time trying to fix it?

gdh1995 · 2020-02-05T00:31:51Z

so, the zoom is not equal with DPI when the 'open in low resolution' unchecked? when you checked it, are the two values keeping the same? I've found a Chrome's runtime flag of "--enable-use-zoom-for-dsf" and it causes the same buggy behavior on Win 10, if just disable it (aka. "enable-use-zoom-for-dsf=false"). So, I have decided to fix it, by adding an extra step before linkhints really executes. Vimium C can access the real zoom radio using an extension API, but I once think it takes more time so haven't adopted it.

…

---Original--- From: "Ag Ibragimov"<notifications@github.com> Date: Wed, Feb 5, 2020 03:21 AM To: "gdh1995/vimium-c"<vimium-c@noreply.github.com>; Cc: "Comment"<comment@noreply.github.com>;"Dahan Gong"<gdh1995@qq.com>; Subject: Re: [gdh1995/vimium-c] Hinting fails with zoom levels above certain threshold (#119) I'm not following you, with "open in low resolution" I can no longer reproduce the bug. Only when the checkbox is "off" I can reproduce it, and only on the Macbooks internal display. Maybe it's really not worth wasting time trying to fix it? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

now accept a zoom only if it's from the DOM attribute of "style". See #119 (comment) .

gdh1995 · 2020-02-05T12:50:17Z

So please try this - I've marked most getComputedStyle(documentElement).zoom untrusted - then it should work when you uncheck the "low resolution" box.

vimium_c-1.80.1-chrome-6ec887c.zip

there're at least 3 kinds of docEl's zoom, even when it's not set: * `pageZoom * screen DPI`, on Chrome for Windows * `pageZoom` only, while renderer follows screen DPI, on Chrome for macOS * `pageZoom` only, and render does not follow screen DPI * if `--enable-use-zoom-for-dsf=false` or "Open in Low Resolution" on macOS

agzam · 2020-02-12T01:09:47Z

Tried that. "Open in low resolution" is unchecked. You have fixed it! Thank you very much!

gdh1995 · 2020-02-12T01:35:23Z

OK.

The v1.80.2 is being published to Chrome Web Store (waiting for verifying). However it can not support zoom changes - only the first page-zoom value will be recognized, because of a typo. This will be fixed in a next version of Vimium C.

gdh1995 · 2020-02-24T03:20:26Z

v1.80.3 has been published, and it supports: 1. show Link Hints and hide; 2. change page zoom level; 3. show LinkHint again.

This comment has been minimized.

Sign in to view

agzam changed the title ~~Missing links~~ Hinting fails with zoom levels above certain threshold Feb 3, 2020

This comment has been minimized.

Sign in to view

gdh1995 added a commit that referenced this issue Feb 5, 2020

docZoom: it's impossible to figure out if a computed.zoom is real

6ec887c

now accept a zoom only if it's from the DOM attribute of "style". See #119 (comment) .

gdh1995 changed the title ~~Hinting fails with zoom levels above certain threshold~~ LinkHints gets a wrong view area if page is zoomed on Chrome for macOS Feb 9, 2020

gdh1995 closed this as completed Feb 24, 2020

gdh1995 added bug chrome-only labels Mar 4, 2020

LinkHints gets a wrong view area if page is zoomed on Chrome for macOS #119

LinkHints gets a wrong view area if page is zoomed on Chrome for macOS #119

Comments

agzam commented Feb 2, 2020 • edited Loading

This comment has been minimized.

Monirzadeh commented Feb 2, 2020 • edited Loading

This comment has been minimized.

This comment has been minimized.

Monirzadeh commented Feb 2, 2020 • edited Loading

This comment has been minimized.

Monirzadeh commented Feb 2, 2020 • edited Loading

gdh1995 commented Feb 2, 2020 via email

This comment has been minimized.

gdh1995 commented Feb 3, 2020

This comment has been minimized.

gdh1995 commented Feb 3, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

gdh1995 commented Feb 3, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

gdh1995 commented Feb 3, 2020

This comment has been minimized.

This comment has been minimized.

gdh1995 commented Feb 3, 2020

This comment has been minimized.

This comment has been minimized.

gdh1995 commented Feb 3, 2020

This comment has been minimized.

agzam commented Feb 3, 2020

gdh1995 commented Feb 3, 2020

agzam commented Feb 3, 2020 • edited Loading

This comment has been minimized.

gdh1995 commented Feb 3, 2020

This comment has been minimized.

agzam commented Feb 3, 2020

gdh1995 commented Feb 3, 2020 • edited Loading

agzam commented Feb 3, 2020

gdh1995 commented Feb 3, 2020 • edited Loading

gdh1995 commented Feb 3, 2020

agzam commented Feb 4, 2020

gdh1995 commented Feb 5, 2020 via email • edited Loading

gdh1995 commented Feb 5, 2020

agzam commented Feb 12, 2020 • edited Loading

gdh1995 commented Feb 12, 2020

gdh1995 commented Feb 24, 2020

agzam commented Feb 2, 2020 •

edited

Loading

Monirzadeh commented Feb 2, 2020 •

edited

Loading

Monirzadeh commented Feb 2, 2020 •

edited

Loading

Monirzadeh commented Feb 2, 2020 •

edited

Loading

agzam commented Feb 3, 2020 •

edited

Loading

gdh1995 commented Feb 3, 2020 •

edited

Loading

gdh1995 commented Feb 3, 2020 •

edited

Loading

gdh1995 commented Feb 5, 2020 via email •

edited

Loading

agzam commented Feb 12, 2020 •

edited

Loading