-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of a X3D previewer with the X_ITE library #56
Conversation
@PaulBoon thanks for the pull request! I'm not sure if you say my post on the google group, but we are definitely in the market for a 3D viewer! Please see also: |
@PaulBoon - in terms of a PR - the v1.4 previewers dir is intended to be frozen (so that people deploying from the gdcc repo don't see any changes). If you make your changes in the betatest dir, they are available once merged, and will also get added to the 1.5 version when that comes out. |
@PaulBoon very cool! In addition to |
Thanks for those positive comments, I will update my 'Draft' to use a 1.5 directory and have a look at more types + test with larger models. |
@PaulBoon - just use /previewers/betatest - I'll copy everything there to a 1.5 dir when we release a new version. |
OK, I fixed some things so now it should work with more mimetypes:
I moved the 'code' to the 'betatest' folder, but those curl calls reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the minor changes requested and if you OK my doc edits, I'll go ahead and merge this. That will make it available in the betatest dir from github.io so it will be easier for people to try and do any QA.
After downloading some example files for testing those mimetypes, I discovered that the preview does not always render them optimally. Downloaded sample files from MeshLab at: https://www.meshlab.net/data/sample_meshes.zip |
I just downloaded |
OK - I'll merge to make it easier for people to test. If there's further work to set a useful initial default view or something, just create a new PR. Thanks for the viewer - lots of people are interested! |
Adds a previewer for the x3d format (mime type: model/x3d+xml) using the X_ITE library.
Using that library potentially many other formats can be rendered.
Other libs I tried where x3dom and three.js, X_ITE was the simplest to use.
Solves part of #55
Example (screendump):
Tips for testing:
Use the famous teapot model:
https://www.web3d.org/x3d/content/examples/Basic/CAD/CadTeapot.x3d