Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSA Operations #652

Merged
merged 13 commits into from
Feb 1, 2021
Merged

RSA Operations #652

merged 13 commits into from
Feb 1, 2021

Conversation

mattnotmitt
Copy link
Collaborator

@mattnotmitt mattnotmitt commented Sep 30, 2019 •
edited
Loading

Fulfilling #272.

  • Generate RSA Key Pair
  • RSA Sign
  • RSA Verify
  • RSA Encrypt
  • RSA Decrypt

@mattnotmitt mattnotmitt marked this pull request as ready for review April 7, 2020 20:18
@mattnotmitt
Copy link
Collaborator Author

@d98762625 This PR is ready for review finally btw :)

@binlab
Copy link

binlab commented May 27, 2020

Nice work!

@mattnotmitt
Copy link
Collaborator Author

Currently discussing the issue with the tests in digitalbazaar/forge#783. It does work if we use un-minified forge but I'm not sure we want to do that just so these tests pass.

@d98762625
Copy link
Member

Cheers @mattnotmitt I can take a look tomorrow but this will need the OK from @n1474335 because its a new operation 👍

@Traderain
Copy link

Why isn't this merged?

@mattnotmitt
Copy link
Collaborator Author

Why isn't this merged?

Couple people have asked me this (on Twitter) and after contacting the lead maintainer this is the reply I got:

"Hey, yes I hope to be [back to merging]. My time has been very stretched over the last year, but I hope to get back to it at some point." - @n1474335

@mattnotmitt mattnotmitt mentioned this pull request Jan 25, 2021
Closed
@n1474335 n1474335 merged commit 99eb1cc into gchq:master Feb 1, 2021
@n1474335
Copy link
Member

n1474335 commented Feb 1, 2021

This took a little bit of tidying up regarding UTF-8 input, but I have got the tests working and integrated.

Thanks very much for the time and effort you have put into implementing this!

@n1474335 n1474335 mentioned this pull request Feb 1, 2021
Closed
@mattnotmitt mattnotmitt deleted the rsa branch February 1, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattnotmitt @binlab @d98762625 @Traderain @n1474335