Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate some gazebo::gui events in favor of ign-gui events #595

Merged
merged 10 commits into from
Feb 9, 2021
Merged

Deprecate some gazebo::gui events in favor of ign-gui events #595

merged 10 commits into from
Feb 9, 2021

Conversation

chapulina
Copy link
Contributor

Builds on top of #591

Deprecate events that have been ported to Ignition GUI.

  • Deprecate warnings on v5, remove on v6
  • Emitting side emits both old and new events on v5. This should allow plugins using these events to keep working, with warnings.
  • Receiving side only processes new events. So if any user plugin is emitting the old events expecting our plugins to react, that won't work anymore. I don't think this is likely though.

@chapulina
Depend on ignition-utils1
4768630 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Deprecate some gazebo::gui events in favor of ign-gui events
12452eb 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
revert change from other branch
5b08c2c 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added GUI Gazebo's graphical interface (not pure Ignition GUI) 🏢 edifice Ignition Edifice labels Jan 29, 2021
@chapulina
shapes
fcfb71a 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This was referenced Jan 29, 2021
Merged
Merged
Merged
@chapulina chapulina requested a review from ahcorde February 2, 2021 18:34
@chapulina chapulina mentioned this pull request Feb 2, 2021
Merged
Base automatically changed from chapulina/5/utils1 to main February 2, 2021 18:34
caguero
caguero requested changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@caguero caguero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI isn't happy. There's a style error.

@chapulina
Remove duplicate include
f95d3b3 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Merge branch 'main' into chapulina/5/guievents
a0ff876
@chapulina
Copy link
Contributor Author

There's a style error.

Fixed in f95d3b3

@codecov
Copy link

codecov bot commented Feb 3, 2021 •
edited
Loading

Codecov Report

Merging #595 (13bf1ca) into main (215fe82) will decrease coverage by 0.14%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   77.47%   77.33%   -0.15%     
==========================================
  Files         213      213              
  Lines       12009    12016       +7     
==========================================
- Hits         9304     9292      -12     
- Misses       2705     2724      +19
Impacted Files Coverage Δ
include/ignition/gazebo/gui/GuiEvents.hh 0.00% <0.00%> (ø)
src/gui/plugins/shapes/Shapes.cc 27.77% <0.00%> (-3.48%) ⬇️
.../gui/plugins/transform_control/TransformControl.cc 14.28% <14.28%> (-0.76%) ⬇️
src/SimulationRunner.cc 91.68% <0.00%> (-2.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215fe82...13bf1ca. Read the comment docs.

chapulina and others added 2 commits February 5, 2021 14:34
@chapulina
merged from main
22205a1 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@ahcorde
Merge branch 'main' into chapulina/5/guievents
13bf1ca
@chapulina chapulina merged commit 2bc062d into main Feb 9, 2021
@chapulina chapulina deleted the chapulina/5/guievents branch February 9, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero requested changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @caguero @ahcorde