-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some test - sdf::JointAxis is normalized and some other timers. #314
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
The SDF converter test is failing because it's saving the URI in both formats file and URL. I thought this was fixed here gazebosim/gz-fuel-tools#85
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
I checked that there are some common parts with this other PR https://github.com/ignitionrobotics/ign-gazebo/pull/288/files
|
@osrf-jenkins run tests please |
1 similar comment
@osrf-jenkins run tests please |
I created an issue for this: #322 |
The joint axis failures should be fixed since #288 |
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 77.19% 77.19%
=======================================
Files 200 200
Lines 10641 10641
=======================================
Hits 8214 8214
Misses 2427 2427
Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com> Removed changes to diff-drive command when backporting to ign-gazebo3 Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com> Removed changes to diff-drive command when backporting to ign-gazebo3 Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com> Removed changes to diff-drive command when backporting to ign-gazebo3 Signed-off-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Blake McHale <mchale.blake@gmail.com>
Signed-off-by: ahcorde ahcorde@gmail.com