Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy fixes: use empty(), fix includes #2548

Merged
merged 2 commits into from
Aug 27, 2024
Merged

clang-tidy fixes: use empty(), fix includes #2548

merged 2 commits into from
Aug 27, 2024

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fix assorted clang-tidy complaints

Summary

  • e7c2951 Check that a container is not empty() rather than compare size() > 0
  • Assorted include-what-you-use fixes: add missing headers, remove unused headers, alphabetize

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
clang-tidy: check !empty(), not compare to size()
e7c2951 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
clang-tidy: include what you use
166d8fe 
Add missing, remove unused headers, alphabetize.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from mjcarroll as a code owner August 27, 2024 01:01
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 27, 2024
@scpeters scpeters merged commit 1784944 into gz-sim8 Aug 27, 2024
9 of 10 checks passed
@scpeters scpeters deleted the scpeters/clang-tidy-8 branch August 27, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@azeey azeey azeey approved these changes

@shameekganguly shameekganguly Awaiting requested review from shameekganguly

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scpeters @azeey @iche033