Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update triggered publisher tutorial #2150

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Update triggered publisher tutorial #2150

merged 2 commits into from
Sep 15, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 14, 2023

🦟 Bug fix

gazebosim/gazebo_test_cases#388

Summary

Removed duplicate section at the end and add one more instruction to show how to reset the vehicle pose

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033
update triggered publisher tutorial
bbb04b7 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from mabelzhang as a code owner September 14, 2023 22:40
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 14, 2023
@iche033 iche033 mentioned this pull request Sep 14, 2023
Closed
2 tasks
ahcorde
ahcorde approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit

tutorials/triggered_publisher.md Outdated Show resolved Hide resolved
@iche033
bash cmd
140fe2f 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #2150 (bc072a0) into gz-sim8 (2388193) will increase coverage by 0.01%.
Report is 3 commits behind head on gz-sim8.
The diff coverage is n/a.

❗ Current head bc072a0 differs from pull request most recent head 140fe2f. Consider uploading reports for the commit 140fe2f to get more accurate results

@@             Coverage Diff             @@
##           gz-sim8    #2150      +/-   ##
===========================================
+ Coverage    65.45%   65.47%   +0.01%     
===========================================
  Files          323      323              
  Lines        30704    30704              
===========================================
+ Hits         20096    20102       +6     
+ Misses       10608    10602       -6

see 1 file with indirect coverage changes

@iche033 iche033 merged commit c8d16bf into gz-sim8 Sep 15, 2023
@iche033 iche033 deleted the update_triggered_publisher branch September 15, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang mabelzhang is a code owner

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iche033 @ahcorde