Fix use of actors that only has trajectory animation #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
iche033
changed the title
mjcarroll
reviewed
Mar 31, 2023
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1947 +/- ##
================================================
- Coverage 78.00% 65.29% -12.71%
================================================
Files 255 327 +72
Lines 15041 26893 +11852
================================================
+ Hits 11732 17561 +5829
- Misses 3309 9332 +6023
... and 116 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mjcarroll
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #1932
Summary
Fixes the case when actors are used without a mesh with animations
More info:
Actor support in gz assumes that actors are always used with a skin mesh and a mesh with skeleton animations. It was found in #1932 that this is not the case in gazebo-classic. Trajectory animation should still work without any meshes or built-in animations. This PR makes the use of skin mesh and animations optional in gz so that users can use actors with just trajectory animation.
To Test:
Run the
test/actor_trajectory.sdf worldandINTEGRATION_actor_trajectorytest.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.