Fix loading worlds from CLI #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
added
bug
This was referenced Aug 3, 2022
Merged
jennuine
approved these changes
Aug 3, 2022
|
Is homebrew expected to be broken? It's looking for gz-gazebo3. |
|
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1627 +/- ##
===============================================
+ Coverage 77.94% 77.98% +0.04%
===============================================
Files 255 255
Lines 15039 15041 +2
===============================================
+ Hits 11722 11730 +8
+ Misses 3317 3311 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
I introduced a critical bug right at the end of #1536 when I added a test. I moved the logic to publish a starting world into the
if (!hasSdfFile && _waitGui && !isPlayback), which means that when the user tries to load any world, i.e.ign gazebo shapes.sdf, the server hangs forever waiting for a starting world from the GUI, and the GUI never sends it.The solution is to always publish the starting world if
_waitGui, even ifhasSdfFile.To test the fix, run:
ign gazebo shapes.sdf- shouldn't hangUNIT_Gui_TEST- should pass even with this changeChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸