Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed GUI's ComponentInspector light parameter #1018

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Fixed GUI's ComponentInspector light parameter #1018

merged 2 commits into from
Sep 8, 2021

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Sep 8, 2021

🦟 Bug fix

Summary

This PR fixes the issue of the parameter for lights no longer appearing in the Component Inspector plugin.

Before PR:
Peek 2021-09-08 11-38

After PR:
Peek 2021-09-08 11-39

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@jennuine jennuine requested a review from chapulina September 8, 2021 18:48
@jennuine jennuine self-assigned this Sep 8, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 8, 2021
@chapulina chapulina added the GUI Gazebo's graphical interface (not pure Ignition GUI) label Sep 8, 2021
chapulina
chapulina approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! That was probably introduced on a bad merge.

@chapulina chapulina merged commit a04b4c7 into ign-gazebo4 Sep 8, 2021
@chapulina chapulina deleted the jennuine/gui_light_fix branch September 8, 2021 18:57
This was referenced Sep 10, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@jennuine jennuine

Labels
🔮 dome Ignition Dome GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennuine @chapulina