Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel updates for msgs6 #95

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Bazel updates for msgs6 #95

merged 1 commit into from
Jul 13, 2021

Conversation

mjcarroll
Copy link
Contributor

Rebase the bazel branch to be off of msgs6, the version used in dome.

Specific cleanups and feedback incorporated in b4b3550
This will replace the current bazel branch.

@mjcarroll mjcarroll requested a review from caguero as a code owner October 23, 2020 19:21
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Oct 23, 2020
@mjcarroll mjcarroll marked this pull request as draft October 23, 2020 19:21
@chapulina
Copy link
Contributor

This will replace the current bazel branch.

You mean bazel-msgs6 or ign-msgs6? i.e. is this PR expected to be merged?

@mjcarroll
Copy link
Contributor Author

You mean bazel-msgs6 or ign-msgs6? i.e. is this PR expected to be merged?

This is expected to be merged.

src/Factory_TEST.cc Outdated Show resolved Hide resolved
@chapulina chapulina removed the 🏢 edifice Ignition Edifice label Mar 18, 2021
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll marked this pull request as ready for review April 27, 2021 20:16
@mjcarroll
Copy link
Contributor Author

Since this is now a purely bazel update, @mahiuchun's approval will be sufficient.

@mjcarroll mjcarroll merged commit ebb4bce into ign-msgs6 Jul 13, 2021
@mjcarroll mjcarroll deleted the bazel-msgs6 branch July 13, 2021 18:15
@chapulina chapulina mentioned this pull request Jul 20, 2021
8 tasks
@caguero caguero mentioned this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants