Bazel updates for Harmonic #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
force-pushed
the
mjcarroll/bazel_harmonic
branch
from
6c5875b to
78146c1
Compare
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
mjcarroll
force-pushed
the
mjcarroll/bazel_harmonic
branch
from
78146c1 to
4795e34
Compare
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-msgs10 #397 +/- ##
==========================================
Coverage 98.19% 98.19%
==========================================
Files 27 27
Lines 1166 1166
==========================================
Hits 1145 1145
Misses 21 21 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
caguero
reviewed
Mar 8, 2024
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
|
@caguero CI running here: gazebosim/gz-bazel#75 |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
mjcarroll
force-pushed
the
mjcarroll/bazel_harmonic
branch
from
4964687 to
317d704
Compare
shameekganguly
approved these changes
Apr 2, 2024
| deps = [ | ||
| ":gzmsgs_proto", | ||
| "@com_google_protobuf//:any_proto", | ||
| "@com_google_protobuf//:protobuf", |
There was a problem hiding this comment.
Do we need to add @com_google_protobuf//:any_cc_proto to deps?
There was a problem hiding this comment.
I believe it's not a target in this version of protobuf:
$ bazel query "@com_google_protobuf//:*"
@com_google_protobuf//:BUILD
@com_google_protobuf//:any_proto
@com_google_protobuf//:api_proto
@com_google_protobuf//:cc_test_protos_genproto
@com_google_protobuf//:cc_toolchain
@com_google_protobuf//:cc_wkt_protos
@com_google_protobuf//:cc_wkt_protos_genproto
@com_google_protobuf//:compiler_plugin_proto
@com_google_protobuf//:descriptor_proto
@com_google_protobuf//:duration_proto
@com_google_protobuf//:empty_proto
@com_google_protobuf//:field_mask_proto
@com_google_protobuf//:java_toolchain
@com_google_protobuf//:javalite_toolchain
@com_google_protobuf//:linux-aarch64
@com_google_protobuf//:linux-ppc
@com_google_protobuf//:linux-s390x
@com_google_protobuf//:linux-x86_32
@com_google_protobuf//:linux-x86_64
@com_google_protobuf//:macos-aarch64
@com_google_protobuf//:macos-x86_64
@com_google_protobuf//:objectivec
@com_google_protobuf//:protobuf
@com_google_protobuf//:protobuf_headers
@com_google_protobuf//:protobuf_java
@com_google_protobuf//:protobuf_java_util
@com_google_protobuf//:protobuf_javalite
@com_google_protobuf//:protobuf_lite
@com_google_protobuf//:protobuf_objc
@com_google_protobuf//:protobuf_python
@com_google_protobuf//:protobuf_python_genproto
@com_google_protobuf//:protoc
@com_google_protobuf//:protoc_lib
@com_google_protobuf//:python_common_test_protos_genproto
@com_google_protobuf//:python_specific_test_protos_genproto
@com_google_protobuf//:source_context_proto
@com_google_protobuf//:struct_proto
@com_google_protobuf//:timestamp_proto
@com_google_protobuf//:type_proto
@com_google_protobuf//:well_known_type_protos
@com_google_protobuf//:windows-x86_32
@com_google_protobuf//:windows-x86_64
@com_google_protobuf//:wrappers_proto
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.