-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cubemap_uri to sky #306
Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Test failures look to be unrelated. Any chance you would want to address them here or is this time-critical? |
Actually, is this supposed to be targeting main or |
This is suppose to target main because msgs9 has already been released. I could squint my eyes and sneak this into |
Test failures look to be unrelated (bash completion flags). |
Wait, we're doing skybox for Fortress, which is still on msgs8 right? |
This is not needed for the skybox work. The skybox work uses the header map in the sky message. This is here to replace that method in the future. |
Waiting on gz-sim7 to main forward port. |
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 9 9
Lines 1073 1073
=======================================
Hits 1027 1027
Misses 46 46 |
🎉 New feature
Summary
Added a
cubemap_uri
string to thesky.proto
message, which supports gazebosim/sdformat#1037.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.