Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added continuous joint type #215

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Added continuous joint type #215

merged 1 commit into from
Jan 20, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jan 19, 2022

Signed-off-by: Nate Koenig nate@openrobotics.org

🎉 New feature

Summary

SDF has a continuous joint type, which was missing in the joint message.

Test it

Run the tests

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from caguero as a code owner January 19, 2022 19:18
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #215 (a8d909b) into main (d64ad09) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   84.56%   84.65%   +0.08%     
==========================================
  Files           7        7              
  Lines         855      860       +5     
==========================================
+ Hits          723      728       +5     
  Misses        132      132              
Impacted Files Coverage Δ
src/Utility.cc 82.28% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64ad09...a8d909b. Read the comment docs.

@nkoenig nkoenig merged commit 9a8b092 into main Jan 20, 2022
@nkoenig nkoenig deleted the continuous_joint branch January 20, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants