Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action does not complete and causes the parent workflow to fail. (triggered by pull request from fork) #42

Closed
julienloizelet opened this issue May 24, 2024 · 2 comments
Closed

Action does not complete and causes the parent workflow to fail. (triggered by pull request from fork) #42

julienloizelet opened this issue May 24, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@julienloizelet
Copy link

julienloizelet commented May 24, 2024 •
edited
Loading

For some reason, one of our actions fails and it seems to be due to the keepalive-workflow step:

https://github.com/justafish/ddev-drupal-core-dev/actions/runs/9213831558/job/25348604861

As you can see, the logs states that the action starts:

Executing keepalive for parent workflow (justafish/ddev-drupal-core-dev/.github/workflows/tests.yml)

But there is nothing after this: I expect to have Nothing to do ... or Kept the repo active using GitHub API

I assume that the step does not end with an exit code 0, which causes the workflow to fail.

More information:

  • we are using here 0 as time_elapsed
  • this is a workflow triggered by a pull request (coming from a fork)

Do you have any idea of what could be the problem ?

Thanks!
@julienloizelet julienloizelet mentioned this issue May 24, 2024
Merged
@julienloizelet
Copy link
Author

julienloizelet commented May 24, 2024 •
edited
Loading

After a little more debugging, I was able to reproduce this behavior.

It appears for me to be related to a workflow triggered by a pull request coming from a fork...

I think it's perfectly legitimate for a PR not to be able to trigger the "keep alive" API call: but perhaps you could do something to avoid this error? (and/or add an explicit log message ?)

Thanks

@julienloizelet julienloizelet changed the title Action does not complete and causes the parent workflow to fail. Action does not complete and causes the parent workflow to fail. (triggered by pull request from fork) May 24, 2024
@gautamkrishnar
Copy link
Owner

@julienloizelet thanks for the suggestion, yep this can be added. A check for pr and a message would be fine in this case. Will add that.

@gautamkrishnar gautamkrishnar added the enhancement New feature or request label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gautamkrishnar @julienloizelet