Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --insecure-no-password #497

Open
yushiyangk opened this issue Sep 25, 2024 · 2 comments
Open

Support --insecure-no-password #497

yushiyangk opened this issue Sep 25, 2024 · 2 comments
Labels
enhancement New feature or request p1

Comments

@yushiyangk
Copy link

yushiyangk commented Sep 25, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
I would like to create backups of non-confidential files without password encryption.

Describe the solution you'd like
Since restic 0.17, the --insecure-no-password flag has been supported to allow creation of repos without password encryption. It would be great if Backrest could support this flag also.

Right now if I try to create a repo without a password, I get an error message saying

Missing repo password. Either provide a password or set one of the env variables RESTIC_PASSWORD, RESTIC_PASSWORD_COMMAND, RESTIC_PASSWORD_FILE.

Perhaps there can be a checkbox for disabling the password? Alternatively, if the goal is to discourage passwordless backups, could the error condition be updated to allow no password to be set when --insecure-no-password is added as a flag?

Thank you!
@yushiyangk yushiyangk added the enhancement New feature or request label Sep 25, 2024
@yushiyangk yushiyangk reopened this Sep 25, 2024
@garethgeorge
Copy link
Owner

Hey, very reasonable. The blocker here at the moment is just a UI validation: https://github.com/garethgeorge/backrest/blob/main/webui/src/views/AddRepoModal.tsx#L690-L738 . The existing validation should additionally check what flag overrides have been specified (I think a simple substring search for --insecure-no-password would be sufficient).

This should be supported out of the box by the daemon. I'm about to leave on vacation so I won't get to this for a few weeks, but it should be very straightforward.

@caiotizio
Copy link

i'm also interested in this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@caiotizio @garethgeorge @yushiyangk