Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Non-Kube-Apiserver AdvertisedAddresses #412

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Filter Non-Kube-Apiserver AdvertisedAddresses #412

merged 1 commit into from
Mar 18, 2024

Conversation

petersutter
Copy link
Member

@petersutter petersutter commented Mar 15, 2024 •
edited
Loading

What this PR does / why we need it:
This PR updates the generation process of the gardenlogin kubeconfig to filter the Shoot.status.advertisedAddresses and only include the kube-apiserver addresses. This change is necessary because, as of gardener/gardener v1.91.0, the advertisedAddresses might also include the service-account-issuer url.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `gardenlogin` kubeconfig now only includes kube-apiserver addresses from `Shoot.status.advertisedAddresses`. This ensures compatibility with `gardener/gardener` version `v1.91.0` and later.

@petersutter petersutter requested a review from a team as a code owner March 15, 2024 17:25
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 15, 2024
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 15, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 15, 2024
grolu
grolu approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 15, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 15, 2024
@petersutter petersutter requested a review from holgerkoser March 18, 2024 12:52
holgerkoser
holgerkoser approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@petersutter petersutter merged commit 315af70 into master Mar 18, 2024
8 checks passed
@petersutter petersutter deleted the bug/gep-24 branch March 18, 2024 13:17
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 18, 2024
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@petersutter @holgerkoser @grolu @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot