Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: List pending nodes #368

Merged
merged 7 commits into from
Jan 17, 2024
Merged

ssh: List pending nodes #368

merged 7 commits into from
Jan 17, 2024

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
#347 added support for the ssh command completion for pending nodes, in addition to the completion of nodes that have already joined the cluster.

This PR also outputs the pending nodes (along with the joined nodes) when executing the ssh command.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`ssh`: Now outputs pending `Node`s in addition to already joined `Node`s.

@petersutter petersutter requested a review from a team as a code owner January 16, 2024 22:20
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 16, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 16, 2024
@petersutter petersutter mentioned this pull request Jan 16, 2024
Closed
@tedteng
Copy link
Contributor

tedteng commented Jan 17, 2024

It seems 043d835 missing, it fix the issue [controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.

image

tedteng
tedteng reviewed Jan 17, 2024
View reviewed changes
pkg/cmd/ssh/connect_information.go Outdated
@@ -124,7 +133,12 @@ func NewConnectInformation(
}
}

nodeList = append(nodeList, n)
nodeSet[n.Name] = n
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea here, very smart.

@petersutter
Copy link
Member Author

right, I have created a separate PR for this fix with the logger #369

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 17, 2024
holgerkoser
holgerkoser approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024
grolu
grolu approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@petersutter petersutter merged commit 14263b4 into master Jan 17, 2024
8 checks passed
@petersutter petersutter deleted the enh/list-machines branch January 17, 2024 17:24
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 17, 2024
@petersutter petersutter mentioned this pull request Jan 17, 2024
Closed
@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedteng tedteng tedteng left review comments

@grolu grolu grolu approved these changes

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@petersutter @tedteng @holgerkoser @grolu @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot