Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: improve ssh command description #316

Merged
merged 1 commit into from
Sep 6, 2023
Merged

ssh: improve ssh command description #316

merged 1 commit into from
Sep 6, 2023

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
Improved text which describes how to manually connect using ssh

  • Execute command in a separate terminal window
  • If the command includes a placeholder, the user is hinted to replace it accordingly
  • Added > prefix to better distinguish regular regular output from the ssh-command to copy

Which issue(s) this PR fixes:
Fixes #315

Special notes for your reviewer:

Release note:

Improved text which describes how to manually connect using ssh

@petersutter petersutter requested a review from a team as a code owner June 1, 2023 14:52
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jun 1, 2023
@petersutter
Copy link
Member Author

/invite @RaphaelVogel

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 1, 2023
RaphaelVogel
RaphaelVogel reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@RaphaelVogel RaphaelVogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 1, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 1, 2023
grolu
grolu approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@petersutter petersutter force-pushed the enh/improve-ssh-command-description branch from 81cce2a to 067c368 Compare September 6, 2023 11:45
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 6, 2023
@petersutter petersutter merged commit b7ded1a into master Sep 6, 2023
@petersutter petersutter deleted the enh/improve-ssh-command-description branch September 6, 2023 11:49
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 6, 2023
@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaphaelVogel RaphaelVogel RaphaelVogel left review comments

@grolu grolu grolu approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ssh improve text which describes how to manually connect using ssh
6 participants
@petersutter @RaphaelVogel @grolu @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot