Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: add flag to confirm access restrictions #309

Merged
merged 3 commits into from
May 31, 2023
Merged

ssh: add flag to confirm access restrictions #309

merged 3 commits into from
May 31, 2023

Conversation

petersutter
Copy link
Member

@petersutter petersutter commented May 25, 2023 •
edited
Loading

What this PR does / why we need it:
This PR adds a new flag called --confirm-access-restriction to the ssh command. It functions similarly to the now deprecated --force flag of the provider-env command.

The provider-env command has also been updated to include the --confirm-access-restriction flag, which replaces the deprecated --force flag. The --force flag will eventually be removed in a future version.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`ssh`: Added flag `--confirm-access-restriction`. Using this flag bypasses the need for confirmation of any access restrictions. Set this flag only if you are fully aware of the access restrictions.
`provider-env`: ⚠️ The `--force` is now deprecated. Use `--confirm-access-restriction` flag instead. The `--force` flag will eventually be removed in a future version.

@petersutter petersutter requested a review from a team as a code owner May 25, 2023 13:08
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels May 25, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 25, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2023
@petersutter petersutter force-pushed the enh/confirm-access-restriction branch from 762bd35 to 03cc506 Compare May 25, 2023 13:29
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2023
@petersutter petersutter force-pushed the enh/confirm-access-restriction branch from 03cc506 to 83a2954 Compare May 25, 2023 13:42
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2023
@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label May 26, 2023
holgerkoser
holgerkoser approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 31, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 31, 2023
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label May 31, 2023
@gardener-robot
Copy link

@petersutter You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label May 31, 2023
@petersutter petersutter force-pushed the enh/confirm-access-restriction branch from 83a2954 to 1061bb1 Compare May 31, 2023 12:15
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 31, 2023
@petersutter petersutter merged commit 09bf5b9 into master May 31, 2023
@petersutter petersutter deleted the enh/confirm-access-restriction branch May 31, 2023 12:48
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petersutter @gardener-robot @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3