Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resolve command #306

Merged
merged 6 commits into from
May 31, 2023
Merged

Add resolve command #306

merged 6 commits into from
May 31, 2023

Conversation

petersutter
Copy link
Member

@petersutter petersutter commented May 17, 2023 •
edited
Loading

What this PR does / why we need it:
This PR adds a resolve command to resolve the current target.

With this command it is possible to resolve the target e.g. to shoot.

$ gardenctl target --garden landscape-dev --seed myseed
Successfully targeted seed "myseed"
$ gardenctl target view -oyaml
garden: landscape-dev
seed: myseed

Resolving this target to a shoot is possible in case it is a managed seed

$ gardenctl resolve shoot
garden:
  alias: dev
  name: landscape-dev
project:
  name: garden
  namespace: garden
seed:
  name: my-soil
shoot:
  name: myseed
  namespace: garden

Which issue(s) this PR fixes:
Fixes #288

Special notes for your reviewer:

Release note:

Added `resolve` command in order to resolve garden, seed, project or shoot for the current target. This command is particularly useful when you need to understand which shoot the current target translates to, regardless of whether a seed or a shoot is targeted.

@petersutter petersutter requested a review from a team as a code owner May 17, 2023 17:18
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 17, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 17, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 17, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 22, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 22, 2023
@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label May 23, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 30, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 31, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 31, 2023
@petersutter petersutter requested a review from holgerkoser May 31, 2023 09:50
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 31, 2023
holgerkoser
holgerkoser approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 31, 2023
@gardener-robot gardener-robot removed the needs/second-opinion Needs second review by someone else label May 31, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 31, 2023
@petersutter petersutter merged commit 6d0ecb3 into master May 31, 2023
@petersutter petersutter deleted the enh/resolve-cmd branch May 31, 2023 11:41
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add get shoot command
6 participants
@petersutter @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot