Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Target provider should merge target with targetFlags #295

Merged
merged 2 commits into from
May 12, 2023

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
The target provider should merge the target with targetFlags.
It always returns a new copy of the target

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label May 8, 2023
@petersutter petersutter requested a review from a team as a code owner May 8, 2023 16:17
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 8, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 8, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 8, 2023
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 12, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2023
@petersutter petersutter force-pushed the enh/merge-target-with-flags branch from ce2155f to 276caa0 Compare May 12, 2023 09:55
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2023
@petersutter petersutter merged commit a0bf3ce into master May 12, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 12, 2023
@petersutter petersutter deleted the enh/merge-target-with-flags branch May 12, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants