Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh add --bastion-name to reuse bastion #283

Merged
merged 3 commits into from
May 2, 2023
Merged

ssh add --bastion-name to reuse bastion #283

merged 3 commits into from
May 2, 2023

Conversation

petersutter
Copy link
Member

@petersutter petersutter commented Apr 27, 2023 •
edited
Loading

What this PR does / why we need it:
add --bastion-name flag. If a bastion with this name doesn't exist, it will be created. If it does exist, the provided public SSH key must match the one used during the bastion's creation.
In addition the --private-key-file flag was added. It must be provided alongside the --public-key-file flag if you want to use a custom keypair. If not provided, gardenctl will either generate a temporary keypair or rely on the user's SSH agent for an available private key.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`ssh`: reuse bastion, e.g. `gardenctl ssh --keep-bastion --bastion-name cli-xxxxxxxx --public-key-file /path/to/ssh/key.pub --private-key-file /path/to/ssh/key`
- `--bastion-name` flag was added. If a bastion with this name doesn't exist, it will be created. If it does exist, the provided public SSH key must match the one used during the bastion's creation
- `--private-key-file` flag was added. It must be provided alongside the `--public-key-file` flag if you want to use a custom keypair. If not provided, gardenctl will either generate a temporary keypair or rely on the user's SSH agent for an available private key.

@petersutter petersutter requested a review from a team as a code owner April 27, 2023 15:42
@gardener-robot gardener-robot added the needs/review Needs review label Apr 27, 2023
@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label Apr 27, 2023
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Apr 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 27, 2023
@petersutter petersutter changed the title ssh add --bastion-nameto reuse bastion ssh add --bastion-name to reuse bastion Apr 27, 2023
@petersutter petersutter force-pushed the enh/reuse-bastion branch from 63b5d04 to 8f54d47 Compare May 2, 2023 11:04
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 2, 2023
@petersutter petersutter force-pushed the enh/reuse-bastion branch from 8f54d47 to c1fd269 Compare May 2, 2023 12:05
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 2, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 2, 2023
holgerkoser
holgerkoser approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels May 2, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 2, 2023
@petersutter petersutter requested a review from grolu May 2, 2023 12:57
grolu
grolu approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@petersutter petersutter merged commit 520c7cd into master May 2, 2023
@petersutter petersutter deleted the enh/reuse-bastion branch May 2, 2023 13:13
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petersutter @holgerkoser @grolu @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot