Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: Abort keepalive on not found #257

Merged
merged 3 commits into from
Mar 20, 2023
Merged

ssh: Abort keepalive on not found #257

merged 3 commits into from
Mar 20, 2023

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
The bastion keepalive is now aborted in case the bastion was deleted

Which issue(s) this PR fixes:
Fixes #232

Special notes for your reviewer:

Release note:

`ssh`: the command will now exit in case the `Bastion` resource was deleted

@petersutter petersutter requested a review from a team as a code owner March 15, 2023 19:24
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 15, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 15, 2023
holgerkoser
holgerkoser approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2023
@petersutter petersutter merged commit 0877bcd into master Mar 20, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 20, 2023
@petersutter petersutter deleted the abort-keepalive-on-not-found branch March 20, 2023 10:20
@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abort keepalive bastion if not found
5 participants
@petersutter @holgerkoser @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot