Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: Add flag to disable keepalive #249

Merged
merged 4 commits into from
Mar 20, 2023
Merged

ssh: Add flag to disable keepalive #249

merged 4 commits into from
Mar 20, 2023

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
This PR adds a --no-keepalive flag that controls if the command should exit after the bastion becomes available.
If this option is true, no SSH connection will be established and the bastion will not be kept alive after it became available.
This option can only be used if KeepBastion is set to true and Interactive is set to false.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`ssh`: You can now disable the keepalive using `--no-keepalive` flag. The command exits after the bastion host became available without keeping the bastion alive or establishing an SSH connection. Note that this flag requires the flags `--interactive=false` and `--keep-bastion` to be set

@petersutter petersutter requested a review from a team as a code owner March 10, 2023 13:51
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 10, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 10, 2023
grolu
grolu approved these changes Mar 11, 2023
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 11, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2023
@petersutter petersutter requested a review from holgerkoser March 16, 2023 18:04
holgerkoser
holgerkoser approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Mar 20, 2023
@gardener-robot
Copy link

@petersutter You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label Mar 20, 2023
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2023
@petersutter petersutter merged commit 5fd2dd9 into master Mar 20, 2023
@petersutter petersutter deleted the no-keepalive branch March 20, 2023 10:20
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 20, 2023
@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@petersutter @gardener-robot @holgerkoser @grolu @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3