Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-2.2] Fix help command not working when session id envs not set #220

Merged
merged 3 commits into from
Feb 17, 2023
Merged

[hotfix-2.2] Fix help command not working when session id envs not set #220

merged 3 commits into from
Feb 17, 2023

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
Fix help command not working when session id envs not set

Which issue(s) this PR fixes:
Fixes #216

Special notes for your reviewer:

Release note:

Fixes an issue where the `help` command did not work anymore in case `GCTL_SESSION_ID` or `TERM_SESSION_ID` environment variable was not set

@petersutter
Add test for bug #216
05d5c79 
(cherry picked from commit 0174187)
@petersutter
Fix #216 and adapt tests
fd0a565 
(cherry picked from commit d2036d5)
@petersutter petersutter requested a review from a team as a code owner January 24, 2023 15:28
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 24, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 24, 2023
grolu
grolu approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 30, 2023
@petersutter
fix env variable in test
1390537 
(cherry picked from commit c5d8996)
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 13, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 13, 2023
@petersutter petersutter merged commit 0b63294 into hotfix-2.2 Feb 17, 2023
@petersutter petersutter deleted the hf-fix-help branch February 17, 2023 12:26
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

@holgerkoser holgerkoser Awaiting requested review from holgerkoser

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petersutter @grolu @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot