Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: target cmd - only register target flags with higher specificty #206

Merged
merged 3 commits into from
Jan 20, 2023
Merged

enh: target cmd - only register target flags with higher specificty #206

merged 3 commits into from
Jan 20, 2023

Conversation

sven-petersen
Copy link
Contributor

What this PR does / why we need it:

see linked issue

Which issue(s) this PR fixes:
Fixes #195

Special notes for your reviewer:

Release note:

Only allow target flags (`--garden`, ...) with lower specificity when using `target` command

@sven-petersen sven-petersen requested a review from a team as a code owner January 4, 2023 09:03
@gardener-robot gardener-robot added the needs/review Needs review label Jan 4, 2023
@gardener-robot
Copy link

@sven-petersen Thank you for your contribution.

@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jan 4, 2023
@gardener-robot-ci-2
Copy link
Contributor

Thank you @sven-petersen for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@sven-petersen sven-petersen force-pushed the enh/targeting-register-specific-target-flags branch 3 times, most recently from 6876523 to 4076799 Compare January 9, 2023 14:13
petersutter
petersutter reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

pkg/target/target_flags.go Outdated Show resolved Hide resolved
@sven-petersen sven-petersen force-pushed the enh/targeting-register-specific-target-flags branch 2 times, most recently from 2f0e8f7 to e7b2da1 Compare January 12, 2023 10:13
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Jan 12, 2023
@sven-petersen sven-petersen force-pushed the enh/targeting-register-specific-target-flags branch 2 times, most recently from ecfd404 to 2fc5bb1 Compare January 12, 2023 12:16
petersutter
petersutter reviewed Jan 13, 2023
View reviewed changes
pkg/cmd/target/seed.go Outdated Show resolved Hide resolved
petersutter
petersutter reviewed Jan 13, 2023
View reviewed changes
pkg/cmd/target/view.go Outdated Show resolved Hide resolved
@sven-petersen sven-petersen force-pushed the enh/targeting-register-specific-target-flags branch 3 times, most recently from bf94e83 to 3e9b7ae Compare January 16, 2023 14:40
@sven-petersen sven-petersen force-pushed the enh/targeting-register-specific-target-flags branch 2 times, most recently from 0276ae2 to 946bee1 Compare January 17, 2023 07:10
@petersutter petersutter self-requested a review January 17, 2023 15:22
petersutter
petersutter approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 17, 2023
@petersutter petersutter removed the reviewed/lgtm Has approval for merging label Jan 17, 2023
@petersutter petersutter added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 17, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 17, 2023
@sven-petersen sven-petersen force-pushed the enh/targeting-register-specific-target-flags branch from 946bee1 to 461fd9e Compare January 19, 2023 16:20
@holgerkoser holgerkoser added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2023
holgerkoser
holgerkoser approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 20, 2023
@petersutter petersutter merged commit ccadb48 into gardener:master Jan 20, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu Awaiting requested review from grolu

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

target: only target flags which higher specificity shall be available for subcommands
6 participants
@sven-petersen @gardener-robot @gardener-robot-ci-2 @holgerkoser @petersutter @gardener-robot-ci-1