Refactor/global target flags #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sven-petersen Thank you for your contribution. |
gardener-robot
added
needs/review
|
Thank you @sven-petersen for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
sven-petersen
force-pushed
the
refactor/global-target-flags
branch
from
cf836e8 to
21ff854
Compare
petersutter
reviewed
Dec 9, 2022
sven-petersen
force-pushed
the
refactor/global-target-flags
branch
from
537eef0 to
c4fb334
Compare
|
@sven-petersen You need rebase this pull request with latest master branch. Please check. |
petersutter
approved these changes
Dec 9, 2022
gardener-robot
added
reviewed/lgtm
holgerkoser
reviewed
Dec 9, 2022
holgerkoser
approved these changes
Dec 12, 2022
sven-petersen
force-pushed
the
refactor/global-target-flags
branch
from
c4fb334 to
2e2007b
Compare
gardener-robot
added
needs/second-opinion
sven-petersen
force-pushed
the
refactor/global-target-flags
branch
from
2e2007b to
1c40a21
Compare
holgerkoser
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
holgerkoser
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
holgerkoser
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
holgerkoser
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
holgerkoser
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
sven-petersen
force-pushed
the
refactor/global-target-flags
branch
from
7315c7f to
19c104b
Compare
holgerkoser
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Instead of registering the target flags (
--garden,--shoot, ...) on the root cmd they are now registered per command. This way the flags are only available where they have an effect.Which issue(s) this PR fixes:
Fixes #85 (2nd step)
Special notes for your reviewer:
follow up: #195
Release note: