Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/target cluster by alias #185

Merged

Conversation

sven-petersen
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #121

Special notes for your reviewer:

Release note:

Allow targeting of clusters by using an alias instead of the identity

@sven-petersen sven-petersen requested a review from a team as a code owner November 22, 2022 11:25
@gardener-robot
Copy link

@sven-petersen Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 22, 2022
@gardener-robot-ci-3
Copy link
Contributor

Thank you @sven-petersen for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 29, 2022
@sven-petersen sven-petersen force-pushed the enh/target-cluster-by-alias branch from 85bbfd1 to 83890dc Compare November 30, 2022 08:13
pkg/config/config.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Dec 9, 2022
@gardener-robot
Copy link

@sven-petersen You need rebase this pull request with latest master branch. Please check.

@sven-petersen sven-petersen force-pushed the enh/target-cluster-by-alias branch from 6e5dfcc to 4978782 Compare December 9, 2022 13:28
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm (but requires rebase)

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review labels Dec 9, 2022
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sven-petersen sven-petersen force-pushed the enh/target-cluster-by-alias branch 2 times, most recently from 119e13e to dc3b4a0 Compare December 12, 2022 11:52
@holgerkoser holgerkoser added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 12, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 12, 2022
@sven-petersen sven-petersen force-pushed the enh/target-cluster-by-alias branch from dc3b4a0 to a439f42 Compare December 12, 2022 13:58
@holgerkoser holgerkoser added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 12, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 12, 2022
@sven-petersen sven-petersen force-pushed the enh/target-cluster-by-alias branch from a439f42 to d2ad8d3 Compare December 12, 2022 15:52
@petersutter petersutter added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2022
@petersutter petersutter merged commit 49392a5 into gardener:master Dec 13, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 13, 2022
@sven-petersen sven-petersen deleted the enh/target-cluster-by-alias branch December 19, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name (alias) for garden configuration
7 participants