New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: add cmd to patch bastion ipblock/cidr filter #180

Merged

petersutter merged 9 commits into gardener:master from sven-petersen:enh/update-bastion-ipblock

Dec 19, 2022

Contributor

sven-petersen commented Nov 7, 2022

What this PR does / why we need it:

Introduce a new command that allows the update, currently only the CIDR/IPBlock, of an existing bastion host previously created through the ssh command.

Which issue(s) this PR fixes:
Fixes #123

Special notes for your reviewer:

Name of the command needs to be decided on
The new command currently is part of the ssh package as they are closely related. Maybe makes sense to put it in its own package?
Probably the way suggestions for --bastion-name are created, by trying to determine the users name and list bastions created by that user only, needs to be tested further

Release note:

Introduce new command, `ssh-patch`, to update existing bastion resources

sven-petersen requested a review from a team as a code owner

November 7, 2022 15:27

gardener-robot added the needs/review label

petersutter reviewed

View reviewed changes

Member

petersutter left a comment

part 1

pkg/cmd/ssh/ssh_patch_test.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

internal/gardenclient/client.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

petersutter reviewed

View reviewed changes

Member

petersutter left a comment

part 2

pkg/cmd/ssh/ssh_patch.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_test.go Outdated Show resolved Hide resolved

sven-petersen force-pushed the enh/update-bastion-ipblock branch from 8a4d9ec to 2443ea2 Compare

November 10, 2022 08:53

gardener-robot added size/xl needs/second-opinion labels

sven-petersen force-pushed the enh/update-bastion-ipblock branch from 2443ea2 to 8ac9726 Compare

November 10, 2022 09:03

petersutter self-requested a review

November 11, 2022 10:04

holgerkoser reviewed

View reviewed changes

pkg/cmd/ssh/ssh_patch.go Outdated Show resolved Hide resolved

holgerkoser reviewed

View reviewed changes

pkg/cmd/ssh/ssh_patch_export_test.go Outdated Show resolved Hide resolved

holgerkoser reviewed

View reviewed changes

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

holgerkoser reviewed

View reviewed changes

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

holgerkoser reviewed

View reviewed changes

pkg/cmd/ssh/ssh_patch_export_test.go Outdated Show resolved Hide resolved

sven-petersen force-pushed the enh/update-bastion-ipblock branch from 4311ebd to e272423 Compare

November 17, 2022 14:59

sven-petersen requested review from holgerkoser and removed request for petersutter

November 17, 2022 16:07

sven-petersen changed the title ~~feat: add cmd to patch bastion ipblock/cidr filter~~ enh: add cmd to patch bastion ipblock/cidr filter

Member

petersutter commented Nov 23, 2022

/hold need to find a solution for the missing "tokenreviews" permission on regular gardener landscapes

gardener-robot added the reviewed/do-not-merge label

petersutter reviewed

View reviewed changes

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

petersutter reviewed

View reviewed changes

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated Show resolved Hide resolved

pkg/cmd/ssh/ssh_patch_options.go Outdated

+              }
+              func (o *sshPatchOptions) AddFlags(flags *pflag.FlagSet) {
+              	flags.StringArrayVar(&o.CIDRs, "cidr", o.CIDRs, "CIDRs to allow access to the bastion host; if not given, your system's public IPs (v4 and v6) are auto-detected.")

Member

petersutter Nov 23, 2022

also re-use the cidr completion

sven-petersen force-pushed the enh/update-bastion-ipblock branch from e88e55d to 75a171d Compare

November 29, 2022 15:04

petersutter reviewed

View reviewed changes

pkg/cmd/ssh/ssh_patch_utils.go Outdated Show resolved Hide resolved

petersutter approved these changes

View reviewed changes

Member

petersutter left a comment

/lgtm

gardener-robot added reviewed/lgtm and removed needs/review needs/second-opinion labels

sven-petersen force-pushed the enh/update-bastion-ipblock branch from 75a171d to faa9990 Compare

November 30, 2022 09:37

gardener-robot added the needs/second-opinion label

holgerkoser added the reviewed/ok-to-test label

gardener-robot-ci-2 removed the reviewed/ok-to-test label

holgerkoser mentioned this pull request

Allow all authenticated users to create tokenreviews and selfsubjectaccessreviews gardener/gardener#7201

Merged

Member

holgerkoser commented Dec 13, 2022 •

edited

Loading

/hold need to find a solution for the missing "tokenreviews" permission on regular gardener landscapes

I have create a PR gardener/gardener#7201 that give this authorization to all authenticated users.

sven-petersen added 8 commits

December 14, 2022 10:18


          feat: add cmd to patch bastion ipblock/cidr filter

1dbec94


          enh: implement PR feedback

673852c


          enh: PR feedback

911ee17


          enh: PR feedback II

e383000


          enh: improve "ssh utils" interface

8605b2b


          enh: make funcs in listpatcher public

c9e5b4e


          enh: move ssh-patch cmd from ssh into its own package

d508f11


          enh: PR feedback

21a2f6a

update to retrigger hooks

sven-petersen force-pushed the enh/update-bastion-ipblock branch from 1e811d8 to 21a2f6a Compare

December 14, 2022 09:18

Member

petersutter commented Dec 16, 2022

/unhold gardener/gardener#7201 was merged and released

gardener-robot removed the reviewed/do-not-merge label

petersutter added reviewed/ok-to-test reviewed/do-not-merge and removed needs/ok-to-test labels

gardener-robot-ci-1 added needs/ok-to-test and removed reviewed/ok-to-test labels

Member

petersutter commented Dec 16, 2022

> Check Markdown
Error: Diff does not match. Run "make gen-markdown" and commit the generated files
Cause:
diff -x .DS_Store /tmp/build/d56d9853/pull-request-gardener.gardenctl-v2-pr.master/docs/help/gardenctl_ssh-patch.md /tmp/tmp.xIIC3ssiQ2/gardenctl_ssh-patch.md


          update markdown docs

e260c35

petersutter added reviewed/ok-to-test and removed reviewed/do-not-merge needs/ok-to-test labels

gardener-robot-ci-2 added needs/ok-to-test and removed reviewed/ok-to-test labels

petersutter merged commit 6d9b513 into gardener:master

gardener-robot added the status/closed label

sven-petersen deleted the enh/update-bastion-ipblock branch

December 19, 2022 12:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs/ok-to-test needs/second-opinion size/xl status/closed