Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cidr flag completion #175

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Add cidr flag completion #175

merged 1 commit into from
Nov 9, 2022

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
This PR adds cidr flag completion for the ssh command.

The completion returns:

  • the public IPs as cidr using the ipify service
  • the cidrs of the systems network interfaces, excluding down and loopback interfaces.

This adds some convenience for the user to specify the correct CIDR range that should be allowed to access the bastion. Alternatively the user should still be able to specify a different CIDR that is not part of the completion (e.g. because of natting).

Which issue(s) this PR fixes:
Fixes #67

Special notes for your reviewer:

Release note:

`--cidr` flag completion now available for the `ssh` command

@petersutter petersutter requested a review from a team as a code owner November 2, 2022 14:29
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 2, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 2, 2022
@petersutter petersutter force-pushed the enh/ssh-cidr-completion branch from 4888afb to 9303e25 Compare November 3, 2022 07:10
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 3, 2022
holgerkoser
holgerkoser approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 9, 2022
@petersutter petersutter force-pushed the enh/ssh-cidr-completion branch from 9303e25 to 097ca93 Compare November 9, 2022 14:03
@petersutter petersutter added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 9, 2022
@petersutter petersutter merged commit ff4725d into master Nov 9, 2022
@petersutter petersutter deleted the enh/ssh-cidr-completion branch November 9, 2022 14:35
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cidr flag completion on ssh command
5 participants
@petersutter @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot