Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug causing rules to Error with "could not find files in foo" #252

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix bug causing rules to Error with "could not find files in foo" #252

merged 1 commit into from
Jun 17, 2024

Conversation

AleksandarSavchev
Copy link
Member

What this PR does / why we need it:
This PR fixes a bug causing rules to Error with "could not find files in foo" when there were no regular files. This bug was caused due to using the ls command to search for any not checked files. The ls command also returns special files and directories which caused the function to error when there were no regular files.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

A bug causing rules that check files on nodes to error with `could not find files in foo` when there were no regular files in `foo` was fixed.

@AleksandarSavchev AleksandarSavchev requested a review from a team as a code owner June 14, 2024 12:51
@gardener-robot gardener-robot added the needs/review Needs review label Jun 14, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 14, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jun 14, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 14, 2024
dimityrmirchev
dimityrmirchev approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 17, 2024
@AleksandarSavchev AleksandarSavchev added the area/ipcei IPCEI (Important Project of Common European Interest) label Jun 17, 2024
@AleksandarSavchev AleksandarSavchev merged commit 8540078 into gardener:main Jun 17, 2024
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AleksandarSavchev @dimityrmirchev @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot