-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SuPeRfail and READ_COMMAND #1374
Conversation
Hm, the latest SgpViz version that is picked up for the redistribution is 0.998 of 31/05/2008. Was the new one released today? |
e21b835
to
f58b3f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1374 +/- ##
==========================================
+ Coverage 63.11% 63.11% +<.01%
==========================================
Files 970 970
Lines 291996 291984 -12
Branches 12743 12718 -25
==========================================
- Hits 184294 184287 -7
+ Misses 104906 104897 -9
- Partials 2796 2800 +4
|
f58b3f0
to
1f86ea0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, the SgpViz still uses SuPeRfail
What changes does this PR require? |
This PR needlessly breaks compatibility with a package we currently distribute. |
Manuel Delgado, one of the authors of sgpviz, will be at the upcoming GAP Days in Siegen, and I talked with him about preparing a new release of his package there. Assuming that works out, we can probably merge this PR (after it has been rebased) |
@ManuelAFDelgado removed SuPeRfail in gap-packages/sgpviz@fd16cad - now waiting for this to appear in the next release. |
This PR also needs to be rebased |
ad14df2
to
443f875
Compare
I have rebased it now. |
443f875
to
ed7adf1
Compare
Also fixed the |
The FR and ZeroMQInterface packages still use |
Resolved in ZeroMQ, but not yet in FR. @laurentbartholdi would you mind merging gap-packages/fr#23 and making a new release of FR, please? |
ed7adf1
to
b914f74
Compare
Rebased again... |
Thanks to @laurentbartholdi - FR package is released and picked up for the redistribution. Now subject to passing tests, this PR may be merged as soon as the new FR release will appear in the packages-master.tar.gz archive. |
Awesome! Perhaps @laurentbartholdi would also consider looking at the four open PRs for float and merging these, followed by a release? :-) |
Dear Max:
I saw your PR for float (sorry I had missed them), and all are fine except
the "remove extern dependencies". I personally very much prefer packages
*not* to download and install external dependencies, and I reluctantly put
that code in. However, once I tried to remove it, and got complaints from
users who didn't want to do manual installs. Indeed it seems that half the
people are upset by each of the methods.
I definitely agree with you that it shouldn't be necessary to have all the
packages. I'll see into that.
Best, Laurent
|
@laurentbartholdi fair enough. I posted your remark to the relevant PR, gap-packages/float#27 and also added some replies; perhaps we can discuss there? |
As https://github.com/gap-system/gap/wiki/Package-updates-status shows, new Float and FR has been picked up. They are now contained in packages-master.tar.gz. This can be now merged. @fingolfin requested changes - please update your review and merge then! |
See #560. Its time has come.