Find CUDA and set WITH_GPU #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… find_cuda_and_set_with_gpu
wangkuiyi
commented
Jun 21, 2018
cmake/bazel.cmake
Outdated
|
|
||
| if(CUDA_FOUND) | ||
| set(WITH_GPU ON) | ||
| endif(CUDA_FOUND) |
There was a problem hiding this comment.
This if-endif might not be very right as it prevents people from building a non-GPU version on a computer with CUDA installed. Not sure what would be the best solution. @gangliao
There was a problem hiding this comment.
I think we should still keep the logic order of original code. It's very useful if developers want to build a CPU-version on a computer with CUDA installed. @wangkuiyi
cmake -DWITH_GPU=OFF ..
There was a problem hiding this comment.
Also, keyword REQUIRED means CUDA must be founded. find_package(CUDA REQUIRED) will raise the compilation error. So CI will be crashed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17