fix #25: propagate tls.connect options from the origin request to the proxy #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ballinette
commented
May 29, 2020
| @@ -29,8 +29,7 @@ class HttpsProxyAgent extends Agent { | |||
|
|
|||
| socket.once('data', () => { | |||
| const secureSocket = tls.connect({ | |||
| rejectUnauthorized: false, | |||
There was a problem hiding this comment.
Note: I wonder why rejectUnauthorized was hardcoded here with false as default value.
This is quite insecure and should be true by default, and could be overridden with custom request's option if needed
There was a problem hiding this comment.
Well, unfortunately there are no test cases for it & I cannot remember. Will merge it as is and see if anything breaks.
gajus
added a commit
that referenced
this pull request
May 29, 2020
|
🎉 This PR is included in version 2.1.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #25
This adds, when creating SSL connnection, any tls.connect() option that may have been set within the original request.
see:
NB : I tried to make some unit tests for this feature, but did not find a mean to intercept tls.connect() call with the dummy proxy 😞
Any help is welcome for that