Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation to Spanish of "What Is JavaScript Made Of?" #556

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Translation to Spanish of "What Is JavaScript Made Of?" #556

merged 3 commits into from
Jan 14, 2020

Conversation

r41ph
Copy link

@r41ph r41ph commented Jan 2, 2020

Pull request containing a translation of the article "What Is JavaScript Made Of?" to Spanish.

@vercel
Copy link

vercel bot commented Jan 2, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/gaearon/overreactedio/f3iynx87m
✅ Preview: https://overreactedio-git-fork-r41ph-whats-js-made-of.gaearon.now.sh

@carburo carburo self-requested a review January 2, 2020 15:11
carburo
carburo requested changes Jan 9, 2020
View reviewed changes
Copy link
Collaborator

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you so much for your contribution. I made some comments. Check them out. And apologies for the late reply.

src/pages/what-is-javascript-made-of/index.es.md Outdated Show resolved Hide resolved
src/pages/what-is-javascript-made-of/index.es.md Outdated Show resolved Hide resolved
src/pages/what-is-javascript-made-of/index.es.md Outdated Show resolved Hide resolved
src/pages/what-is-javascript-made-of/index.es.md Outdated Show resolved Hide resolved
src/pages/what-is-javascript-made-of/index.es.md Outdated Show resolved Hide resolved
src/pages/what-is-javascript-made-of/index.es.md Outdated Show resolved Hide resolved
src/pages/what-is-javascript-made-of/index.es.md Outdated Show resolved Hide resolved
src/pages/what-is-javascript-made-of/index.es.md Outdated Show resolved Hide resolved
src/pages/what-is-javascript-made-of/index.es.md Outdated Show resolved Hide resolved
src/pages/what-is-javascript-made-of/index.es.md Outdated Show resolved Hide resolved
@r41ph @carburo
Apply suggestions from code review
4aa08a7 
Co-Authored-By: Rainer Martínez Fraga <rmartinezfraga@yandex.com>
@r41ph
Copy link
Author

r41ph commented Jan 11, 2020

Hi, no worries, thanks for reviewing it.

@r41ph r41ph requested a review from carburo January 11, 2020 02:04
@carburo carburo merged commit c85cc4d into gaearon:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carburo carburo Awaiting requested review from carburo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r41ph @carburo