Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pzstd file is not detected as zstd #619

Closed
Koyorice opened this issue Dec 15, 2024 · 2 comments
Closed

pzstd file is not detected as zstd #619

Koyorice opened this issue Dec 15, 2024 · 2 comments

Comments

@Koyorice
Copy link

Koyorice commented Dec 15, 2024 •
edited
Loading

Attach the file for which the detection is inaccurate
test.zip
test.txt.zst uses zstd
test2.txt.zst uses pzstd

Expected MIME type
application/zstd

Returned MIME type
application/octet-stream

Version of the library you are using
v1.4.7

Output of go version
go version go1.23.4 linux/amd64

Additional context
https://github.com/facebook/zstd
Files created using pzstd are not detection correctly, if use file command both will be detected as application/zstd
gabriel-vasile added a commit that referenced this issue Dec 19, 2024
@gabriel-vasile
zstd: check for skippable frames as well; fix #619
0ef5c1e
@gabriel-vasile
Copy link
Owner

Thank you!

@Koyorice
Copy link
Author

Thank you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabriel-vasile @Koyorice