Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.torrent file in testdata getting detected as malicious file and causing build issue. #398

Closed
Amit99Shah opened this issue Jun 8, 2023 · 5 comments

Comments

@Amit99Shah
Copy link

Amit99Shah commented Jun 8, 2023

No description provided.

@gabriel-vasile
Copy link
Owner

@Amit99Shah what's the name of the tool that reports .torrent as malicious?

@gabriel-vasile
Copy link
Owner

.torrent files are not inherently malicious; the testdata torrent.torrent is just downloading an Arch linux iso.

I will gladly fix this problem if the tool that you are using did some thoroughly checks and found malicious intent inside that file. But if it only looked at the extension and deemed it malicious, then I don't think there's anything to fix.

@FurmanovD
Copy link

FurmanovD commented Jun 12, 2023

@gabriel-vasile it's a common practice to avoid any potential legal issues. In my case, it's FortiClient
I also faced this issue because playground/validator has got a dependency on your module.
And I was forced to just downgrade the validator.

@gabriel-vasile
Copy link
Owner

To me, this seems a gross approach from FortiClient.
That being said, I understand how this argument can drag for too long so I'm willing to take steps forward once the problem is clear.

@FurmanovD, @Amit99Shah and anyone else having similar problems, your answers are greatly appreciated.

  1. Is it only .torrent that causes problems?
  2. Does renaming the file .torrent -> .nottorrent silence those "security" tools?
  3. If answer to 2. was no, does encoding the file (zip, base64, etc.) fix the error?
  4. What exactly is the reported problem? Is it security or legal related?

@Amit99Shah
Copy link
Author

@gabriel-vasile Yes, renaming the file will solve this issue

gabriel-vasile added a commit that referenced this issue Oct 24, 2024
continuing removing excessive testfixures #575 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants