Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding lock to rotate_now() #3281

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Adding lock to rotate_now() #3281

merged 1 commit into from
Dec 3, 2024

Conversation

matteodelseppia
Copy link
Contributor

This change fixes a missing lock in the recently introduced rotate_now() of rotating file sinks.

@gabime gabime merged commit 24dde31 into gabime:v1.x Dec 3, 2024
16 checks passed
@gabime
Copy link
Owner

gabime commented Dec 3, 2024

Thanks @matteodelseppia

@hjs-ast hjs-ast mentioned this pull request Dec 3, 2024
Merged
@matteodelseppia matteodelseppia deleted the add_lock_to_rotate_now branch December 3, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteodelseppia @gabime