Added additional information for error handler #2048
Conversation
Useful when formatting log messages fails. Now you can tell which log message caused the problem.
does not work with wchar_t based string.
There's actually a diffent string view type for wide string...
Mixing char types in libfmt is a problem and WIP.
|
Currently, there's still a problem under Windows with wchars... |
|
can you fix it? |
|
It's work in progress. I will continue checking it out when I'm back at work next Tuesday. |
|
Ok, I found the root cause. It's actually SPDLOG_WCHAR_TO_UTF8_SUPPORT. The wstring_view_t format string/message can't just be dumped into fmt::format together with the exception message from what() in two versions of log_. For now, I'm passing an empty string to SPDLOG_LOGGER_CATCH in those two versions of log(). Like that it's no worse than before under Windows. But I'll still check for a nicer solution next week. |
|
Ok. Thanks. I will leave this pr open until fully implemented. |
|
I got a working solution now which also works smoothly under Windows. Instead of emitting the offending log message, the location of the offending log message is reported (filename and line). |
include/spdlog/logger.h
Outdated
| if(location.filename) \ | ||
| { \ | ||
| try \ | ||
| { \ |
There was a problem hiding this comment.
I dont think an extra try catch needed here. why would it fail? the lib is in total control of the source loc param
There was a problem hiding this comment.
I just figured as fmt::format can throw (e.g. in case of OOM), it would be the safest bet to catch.
I'll remove it.
There was a problem hiding this comment.
Thanks, please remove it and I will merge.
|
Alos please note that by default the source_loc is empty unless the SPDLOG_INFO/DEBUG etc macros are used. |
In our case, our own log macros forward to SPDLOG_LOGGER_CALL or add the source_loc themselves. So that's cool. |
The fmt::format call should not throw formatting the exception message and the source code location.
|
Thanks @D-r-P-3-p-p-3-r . Merged. |
Useful when formatting log messages fails. Now you can tell which log message caused the problem.