This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Accept all 2xx and 3xx HTTP status codes as successful #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to: #224 |
|
I agree that 2xx are all successful responses. For the 3xx, I know that they are all redirections, but I wonder if 310 shouldn’t be considered as an error response. What do you think ? |
|
For example in my case I have a Redir Service only replay 301 or 302 and will be great can monitoring the uptime with this tool, for this reason, can be a Flag if the 30x need to be ok or not? configurable option will be great! |
fzaninotto
added a commit
that referenced
this pull request
May 22, 2014
Accept all 2xx and 3xx HTTP status codes as successful
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only 2xx status code that handles as an OK response is "200" but some services I am monitoring return status codes of 201, 202, and 206. I used a match as a catch all for the 2xx and 3xx status code ranges.