Callbacks for Information and Error dialogs #851
Conversation
… and information dialog
dialog/information_test.go
Outdated
| func() { | ||
| select { | ||
| case <-tapped: | ||
| case <-time.After(1 * time.Second): |
There was a problem hiding this comment.
That's way too long IMO.
| case <-time.After(1 * time.Second): | |
| case <-time.After(100 * time.Millisecond): |
There was a problem hiding this comment.
Oh, when using test.Tap you don't have to do concurrency, it's synchronous. However, using a chan and the select makes the test independent from the implementation of test.Tap.
There was a problem hiding this comment.
It looks like this is still 1 second
|
@andydotxyz @toaster Should be fixed now. Hope the solution for saving the callback for Confirm dialogs is OK? |
|
Thanks. |
|
That's great thanks. |
Description:
Motivation: (from #752): "Whenever I display an error message to the user in the error dialog, I'd like to have some way of handling when this window is dismissed.
In the case of my app, any error that I display in the error dialog is a critical one, after which I do not expect the user to continue using the app, thus dismiss action must call: window.Close() and some other cleanup code (e.g. closing DB connection, stopping goroutines).
I think callback function on the error dialog dismiss would be helpful to accomplish this task."
This pull request implements this behaviour for information and error dialogs with new "xxxWithCallback" methods.
Fixes #752
Checklist:
Where applicable: