Fix various issues with how List and Map advertised Get/Set #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required so we can correct Get and Set
AlbinoGeek
reviewed
Jan 2, 2021
AlbinoGeek
approved these changes
Jan 3, 2021
There was a problem hiding this comment.
[ not a reviewer, but ]
Considering the discussion in slack, I think this implementation looks well, and would handle (for example) Unmarshal correctly now. The only missing bit belongs in another PR anyways (concerning the Reload method.)
This feels more consistent with the other binding types. It looks good to me.
Jacalz
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues raised during chat about re-loading data in binding
a) Get and Set were not possible for the underlying list or struct, so the current Get/Set was renamed GetValue/SetValue
b) New Get and Set were added to provide access to the core data, checking for changes where possible for set
c) trigger the container on size/key change and otherwise trigger value listeners if the data item changed.
d) export the
Untypedtype because sometimes we will need it just likeIntChecklist: