Align size and position to closest pixel for crisp output #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
approved these changes
Jan 2, 2021
| func rectInnerCoords(size fyne.Size, pos fyne.Position, fill canvas.ImageFill, aspect float32) (fyne.Size, fyne.Position) { | ||
| if fill == canvas.ImageFillContain || fill == canvas.ImageFillOriginal { | ||
| // change pos and size accordingly | ||
|
|
There was a problem hiding this comment.
Is this newline intended to be here?
There was a problem hiding this comment.
This was just moving the code around to fix ordering, it was a separate commit so you can see it was just that ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most noticable on low resolution screens where the new floating-point position could look fuzzy (most notably text, but also lines etc).
Not only does it now look as crisp as when we used integers I think that on a HiDPI this now looks exceptional :)
Checklist: