Toggle hidden files #1689
Merged
Toggle hidden files #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
requested changes
Dec 27, 2020
|
Doesn't an accordion have to have space to expand into? Isn't a Popup cleaner?
________________________________
From: Stuart Scott <notifications@github.com>
Sent: 27 December 2020 20:00
To: fyne-io/fyne <fyne@noreply.github.com>
Cc: adrianre12 <adrianrevill@hotmail.com>; Author <author@noreply.github.com>
Subject: Re: [fyne-io/fyne] Toggle hidden files (#1689)
@stuartmscott commented on this pull request.
________________________________
In dialog/file.go<#1689 (comment)>:
+
+ left := fyne.NewContainerWithLayout(layout.NewBorderLayout(nil, optionsButton, nil, nil), favoritesGroup, optionsButton)
+
+ return fyne.NewContainerWithLayout(layout.NewBorderLayout(header, footer, left, nil),
+ left, header, footer, body)
+
+}
+
+func (f *fileDialog) optionsMenu(position fyne.Position, buttonSize fyne.Size) {
+ hiddenFiles := widget.NewCheck("Show Hidden Files", func(changed bool) {
+ f.showHidden = changed
+ f.refreshDir(f.dir)
+ })
+ hiddenFiles.SetChecked(f.showHidden)
+
+ title := widget.NewLabel("Options")
Or options could be an Accordion
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1689 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AE4ZV5G5IQ5O4VVTAHPXOQTSW6G57ANCNFSM4VK5EPCQ>.
|
|
This might need to be a separate PR, but we should consider also having a keyboard shortcut/shortcuts. I believe that on macOS, this is command+shift+n, and on Linux it's normally control+h. We might want to either support both and/or toggle it by OS. I don't think this is a blocker for merging this PR, but if it's going to be separated, we should move this into an issue. |
andydotxyz
added
blocker
Co-authored-by: Stuart Scott <stuart.murray.scott@gmail.com>
5 tasks
|
The tests are failing on animations. I think you might need to rebase on develop to get that fixed (if I remember correctly). |
|
@adrianre12 Could you please rebase on develop? |
|
Sry, was having a couple of days off. Merged now and tests passed
…________________________________
From: Jacob <notifications@github.com>
Sent: 04 January 2021 11:57
To: fyne-io/fyne <fyne@noreply.github.com>
Cc: adrianre12 <adrianrevill@hotmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [fyne-io/fyne] Toggle hidden files (#1689)
@adrianre12<https://github.com/adrianre12> Could you please rebase on develop?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1689 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AE4ZV5DDK33YRURSYQTCLULSYGULHANCNFSM4VK5EPCQ>.
|
Jacalz
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a continuation of kgentile's PR #1282
I have attempted to address the outstanding requested changes.
Fixes #1278
Checklist:
This is the dialog/testdata folder not showing hidden files
Clicking Options button pops up a list, at the moment only one entry Show Hidden Files. Clicking this refreshes the file dialog and shows the hidden files. I have included the file .hidden in the testdata folder and ensured it works on windows and Linux.