Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all code to use QSharePointer and std::vector #205

Merged
merged 18 commits into from
Aug 8, 2021
Merged

Refactor all code to use QSharePointer and std::vector #205

merged 18 commits into from
Aug 8, 2021

Conversation

ftylitak
Copy link
Owner

@ftylitak ftylitak commented Aug 7, 2021

Code base was extensivelly using classes: Ref, Counted as a way for reference counted pointers. These classes where replaced by the use of QSharedPointer
Moreover, Array and ArrayRef were replaced by std::vector and QSharedPointerstd::vector.

This PR resolves all warnings/errors produced by Vlargind.

Also, it could solve issues: #202 & #61

ftylitak added 16 commits August 1, 2021 23:50
@ftylitak
change array to vector
a892b38
@ftylitak
changed all Array to std::vector and all ArrayRef to QSharedPointer<s…
ef2e00d 
…td::vector>>
@ftylitak
changed all Ref to QSharedPointer
d601d8e
@ftylitak
fixing compilation errors
7eb571c
@ftylitak
fixing compilation errors
4af0dd5
@ftylitak
fixing compilation errors
5cb7431
@ftylitak
fixing compilation issues
263a8b6
@ftylitak
fix compilation errors
a36b859
@ftylitak
First working version of whole-project use of QSharedData
aee14ae
@ftylitak
refactoring to minimize use of raw pointers and copy constructors
e8fb354
@ftylitak
Merge branch 'master' of https://github.com/ftylitak/qzxing into swit…
ca094ee 
…ch-from-ref-to-shared-pointer
@ftylitak
fix warning of uninitialized values on Pair
ea5b87b
@ftylitak
remove references of Array class that has been deleted
c5df091
@ftylitak
updated project files with Array.h removed
d357890
@ftylitak
CameraImageWrapper::Factory now returns QSharedPointer instead of Raw…
63d4272 
… Pointer

resolves #76
@ftylitak
fix compilation error in CameraImageWrapper
0f768f9
@lgtm-com
Copy link

lgtm-com bot commented Aug 7, 2021

This pull request introduces 7 alerts when merging 0f768f9 into 8a36df7 - view on LGTM.com

new alerts:

  • 7 for Multiplication result converted to larger type

@ftylitak ftylitak merged commit 9f7a1ac into master Aug 8, 2021
This was referenced Aug 8, 2021
Closed
Closed
@StefanoD
Copy link
Contributor

StefanoD commented Dec 11, 2022 •
edited
Loading

Question: Why did you decide to use QSharedPointer instead of std::shared_ptr?
Strange is also the use of QSharedPointer<std::vector>, because here you could use QVector which is a COW data structure. That is, is does a shallow copy per default and a real copy happens only when it gets modified.

@ftylitak
Copy link
Owner Author

Hello @StefanoD

QSharePointer was only used for compatiblity with Qt, just in case someone use the library with C++ earlier than 11.

For the QVector, you are right and it should be done as you say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ftylitak @StefanoD