Move code for replacing versions from Update to UpdateHeuristic #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
+ Coverage 55.89% 56.91% +1.02%
==========================================
Files 64 65 +1
Lines 814 831 +17
Branches 45 38 -7
==========================================
+ Hits 455 473 +18
+ Misses 359 358 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
+ Coverage 55.89% 56.91% +1.02%
==========================================
Files 64 65 +1
Lines 814 831 +17
Branches 45 38 -7
==========================================
+ Hits 455 473 +18
+ Misses 359 358 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose here is to separate the logic for replacing versions from
Updateand to make clear that we're using various heuristics to find the version numbers.