Some maintenance updates to help upcoming .NET 8 migration #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thorium
changed the title
|
Looking the build-logs, it was naive to expect only reference-assemblies have GitHub account under dotnet, because e.g. System.Text.Json can come either from .NET reference assembly or Nuget, and they both have same repository url. I'll try to invent something better. Edit: Further investigation: It might be ok, because it's just a back-up solution. |
xperiandri
approved these changes
Sep 22, 2024
|
Could you rebase on top of the latest master? |
xperiandri
reviewed
Sep 22, 2024
Thorium
force-pushed
the
net6-updates
branch
from
902fd88
to
982bb53
Compare
|
Rebased passing build, now failed for ".NET Core SDK install failed with code", maybe a network error. |
xperiandri
approved these changes
Sep 23, 2024
xperiandri
force-pushed
the
net6-updates
branch
from
b7b00c9
to
33195ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated expired runtime-identifiers to current version:
https://learn.microsoft.com/en-us/dotnet/core/rid-catalog#known-rids
Added few explicit types to places where .NET8 will have multiple overloads so compiler won't be able to pick correct types.
Addressed the issue detecting .NET-assemblies in the future, pointed out here: #2818 (comment)