build.fsx: Reference System.Reactive instead of System.Reactive.Compa… #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperiandri
approved these changes
Sep 22, 2024
xperiandri
force-pushed
the
simpler_reactive
branch
from
75299d0
to
df20450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tibility
Description
Another observation whist looking at other things - build.fsx references the System.Reactive.Compatibility NuGet package and I don't see why -
The nuget.org listing for the package says
This package exists for backwards compatibility, and should not be used by new applications.and it also depends on quite a few other System.Reactive.* packages that don't seem to be used.The only use of System.Reactive that I see in the Fake build is in Fake.Core.Target (via FSharp.Control.Reactive) and the reference in build.fsx does seem to update the reference in the CI build from 5.0 to 6.0.1, but that can be done just by updating System.Reactive directly.
So - could it be changed to simplify the build dependencies?